Skip to content

chore: pre-commit autoupdate + comment out mypy (broken on Python 3.14 bracketless except)#14497

Closed
Copilot wants to merge 4 commits intomasterfrom
copilot/fix-test-failures-and-mypy-issues
Closed

chore: pre-commit autoupdate + comment out mypy (broken on Python 3.14 bracketless except)#14497
Copilot wants to merge 4 commits intomasterfrom
copilot/fix-test-failures-and-mypy-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 2, 2026

Describe your change:

pre-commit autoupdate picked up ruff v0.15.8, which now formats except (E1, E2):except E1, E2: when targeting py314 (Python 3.14 bracketless except). mypy v1.20.0 treats this valid syntax as a fatal parse error, blocking all type checking.

Updates:

  • ruff v0.14.14v0.15.8
  • codespell v2.4.1v2.4.2
  • pyproject-fmt v2.12.1v2.21.0
  • validate-pyproject v0.24.1v0.25
  • mypy v1.19.1v1.20.0 (commented out — see below)

mypy disabled temporarily: mypy v1.20.0 cannot parse except E1, E2: (py314 syntax), causing a fatal [syntax] error that prevents it from checking any file ruff has touched. Commented out with a TODO until mypy supports it.

# - repo: https://github.com/pre-commit/mirrors-mypy
#   ...
#   TODO: re-enable when mypy supports Python 3.14 bracketless except syntax
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.

@cclauss cclauss marked this pull request as ready for review April 2, 2026 00:35
@cclauss cclauss self-requested a review as a code owner April 2, 2026 00:35
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Apr 2, 2026
@cclauss cclauss enabled auto-merge (squash) April 2, 2026 00:35
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Apr 2, 2026
@cclauss cclauss closed this Apr 2, 2026
auto-merge was automatically disabled April 2, 2026 00:50

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants